tests/add-tests-exchange #25
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, this is great work @felipegs31. But since this repo is dependent to the course in the README, I'm not sure about making such a drastic change. However, there's a community testing course that's currently underway in LW3. These kinda tests are SUPER helpful there. Do check the document below : |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added whitelist and nfts contracts to be able to unit test,
removed waffle following https://hardhat.org/hardhat-runner/docs/guides/migrating-from-hardhat-waffle,
added exchange unit tests,
removed unused contracts and scripts
I am practicing how to write good unit tests for contracts, feedbacks are welcome =)
If this content is good, I would be more than happy to add some steps to the readme on my thought process