Open
Conversation
Display myname from Firebase.
add dbGreeting, adUsername
LearningNerd
approved these changes
Jun 24, 2017
Member
LearningNerd
left a comment
LearningNerd
left a comment
There was a problem hiding this comment.
Looks great, @naoever!! 👍 Pull request approved! I'll close it out now that you're done :) One small note though: remember to create a new branch in Git for each new feature or major change that you work on. (I noticed for this one, you reused your firebase-test-no branch instead of creating a new one called something like gh-login-no)
firebase-test/firebasetest.js
Outdated
|
|
||
|
|
||
|
|
||
| // HERE: Update the paragraph with ID of "userinfo" to display the message "Not currently logged in." |
Member
There was a problem hiding this comment.
Minor edit: could move this comment up to just above line 85 since that's what this comment is describing, or just delete the comment :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.