Skip to content

Conversation

@Lance-XI
Copy link
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Updates the basesell of miscellaneous items verified in retail with the proper fame immune vendor.

Steps to test these changes

  • Verify the price of items.
  • Update item_basic.sql
  • Run dbtool and verify changes were successful.

@Lance-XI Lance-XI changed the title Update basesell price for misc items [sql] Update basesell price for several items Dec 29, 2025
@sruon
Copy link
Contributor

sruon commented Jan 5, 2026

Can you add some sort of capture or at least screenshots?

I'm sure the changes are correct but if nothing is attached then someone has to go and double check - wasting everyone's time.

@Lance-XI
Copy link
Contributor Author

Lance-XI commented Jan 5, 2026

I apologize for that and didn't intend to waste anyone's time. These prices were something I verified and recorded awhile ago without a capture. With the recent basesell PR by Siknoz, I wanted to avoid any further duplicated effort by publishing the remaining ones I'd checked.

Xaver contacted me about the lack of verification in this PR and how it could be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants