Skip to content

FIx EditableGridTest failures #2838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-alan merged 1 commit into from
Jan 7, 2026
Merged

FIx EditableGridTest failures #2838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/org/labkey/test/components/ui/grids/EditableGrid.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,7 @@ public EditableGrid shiftSelectRange(int start, int end)
throw new NoSuchElementException("there is no selection column for grid");

var checkBoxes = Locator.tag("tr").child("td")
.child(Locator.byClass("table-cell-content"))
.child(Locator.tagWithAttribute("input", "type", "checkbox"))
.findElements(elementCache().table);
getWrapper().scrollIntoView(checkBoxes.get(start)); // Make sure the header isn't in the way
Expand Down
3 changes: 2 additions & 1 deletion src/org/labkey/test/tests/component/EditableGridTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,12 +459,13 @@ public void testShiftClick()
Tests the scenario where a row is selected, then another, and another are shift-selected
expects the range-bump to redefine the selected range
*/
@Test public void testShiftSelect_bumpSelect()
@Test public void testShiftSelectMultipleTimes()
{
EditableGrid testGrid = goToEditableGrid(PASTING_SAMPLE_TYPE);
testGrid.addRows(15);

Locator boxes = Locator.tag("tr").child("td")
.child(Locator.byClass("table-cell-content"))
.child(Locator.tagWithAttribute("input", "type", "checkbox"));
var checkBoxes = boxes.findElements(testGrid);
scrollIntoView(checkBoxes.get(2), false);
Expand Down