Skip to content

Conversation

@labkey-tchad
Copy link
Member

@labkey-tchad labkey-tchad commented Dec 30, 2025

Rationale

  • If a server problem is causing JUnit tests to time out, we should just stop running the tests instead of running into TeamCity's timeout (generally 2-10 hours).

  • Flow tests fail intermittently when selecting a file. The failure indicates that the file doesn't exist but the screenshot indicates that it does (matching the exact XPath expected by the helper). This isn't a problem with the flow tests in particular. It is a problem with how FileBrowserHelper handles infinite scrolling and most tests don't deal with long enough file lists to ever encounter the issue.

java.lang.AssertionError: File not found: mini-fcs.xml
  at org.labkey.test.util.FileBrowserHelper.checkFileBrowserFileCheckbox(FileBrowserHelper.java:255)
  at org.labkey.test.util.FileBrowserHelper.checkFileBrowserFileCheckbox(FileBrowserHelper.java:241)
  at org.labkey.test.util.FileBrowserHelper.selectFileBrowserItem(FileBrowserHelper.java:144)
  at org.labkey.test.tests.flow.BaseFlowTest.importAnalysis_uploadWorkspace(BaseFlowTest.java:402)
  at org.labkey.test.tests.flow.BaseFlowTest.importAnalysis(BaseFlowTest.java:342)
  at org.labkey.test.tests.flow.FlowJoQueryTest.verifyQueryTest(FlowJoQueryTest.java:100)
  at org.labkey.test.tests.flow.FlowJoQueryTest._doTestSteps(FlowJoQueryTest.java:57)
  • Our project menu doesn't always render the project list successfully after opening. Adding a retry should help. image

Related Pull Requests

  • N/A

Changes

  • Wait for file browser checkbox to appear
  • Stop running server-side JUnit tests after 5 consecutive timeouts
  • Add missing conceptURI to ColumnType.VisitLabel
  • Add retry to ProjectMenu.open

@labkey-tchad labkey-tchad changed the title Prevent cascading JUnit test failures Minor test fixes for intermittent failures Dec 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants