Create a separate package for CommonMark.NET.Console#123
Create a separate package for CommonMark.NET.Console#123sharwell wants to merge 6 commits intoKnagis:masterfrom
Conversation
sharwell
force-pushed
the
console-package
branch
from
daa22d3 to
9eb6538
Compare
sharwell
force-pushed
the
console-package
branch
from
9eb6538 to
3f924d3
Compare
| <projectUrl>https://github.com/Knagis/CommonMark.NET/</projectUrl> | ||
| <iconUrl>https://raw.githubusercontent.com/dcurtis/markdown-mark/master/png/32x20.png</iconUrl> | ||
| <requireLicenseAcceptance>false</requireLicenseAcceptance> | ||
| <summary>Fastest .NET library for converting Markdown documents to HTML.</summary> |
There was a problem hiding this comment.
📝 I didn't see a way to preserve the <summary> element, but I believe I preserved the rest of the metadata.
| <file src="CommonMark\bin\$configuration$\portable-net4+sl5+win+wpa+wp8\CommonMark.*" target="lib\portable-net40+sl50+wp80+win+wpa81+MonoAndroid10+MonoTouch10\" /> | ||
| <file src="CommonMark\bin\$configuration$\portable-net45+win+wpa+wp8\CommonMark.*" target="lib\portable-net45+wp80+win+wpa81+MonoAndroid10+xamarinios10+MonoTouch10\" /> | ||
| <file src="CommonMark\bin\$configuration$\netstandard1.0\CommonMark.*" target="lib\netstandard1.0\" /> | ||
| <file src="CommonMark.Console\bin\$configuration$\net45\CommonMark.Console.exe" target="tools\cmark.exe" /> |
There was a problem hiding this comment.
📝 The tool was moved to a separate NuGet package.
| @@ -0,0 +1,18 @@ | |||
| { | |||
| "$schema": "https://raw.githubusercontent.com/AArnott/Nerdbank.GitVersioning/master/src/NerdBank.GitVersioning/version.schema.json", | |||
| "version": "0.15.1.0", | |||
There was a problem hiding this comment.
📝 This is capable of calculating unique version numbers for each commit on build, but for now I've hard-coded all four digits of the version number to match the behavior prior to this pull request. The partial adoption of Nerdbank.GitVersioning causes the ThisAssembly class to be generated during the build, which is used by InitializeVersion to provide version information now that the nuspec file is generated after the assembly has already been built.
The behavior change introduced by this involves the [AssemblyVersion] and [AssemblyFileVersion] attributes, which now read 0.15.0.0 and 0.15.1.0, respectively. Prior to this change, the NuGet package version was 0.15.1.0, but both of the attributes were 0.1.0.0.
1 participant
Please see the notes in review and feel free to ask any questions before deciding to merge.