Skip to content

Conversation

@williamjallen
Copy link
Collaborator

MySQL doesn't support a boolean type, so CDash has historically used smallints to represent boolean option columns. This can be confusing to developers because there are also multivalued smallint columns. This PR switches all of the binary project option column types to boolean. I also added not-null constraints where appropriate.

Copy link
Member

@josephsnyder josephsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of easy conflicts to fix, but otherwise LGTM!

@williamjallen williamjallen force-pushed the project-boolean-columns branch from 229b07c to 1379d66 Compare January 5, 2026 20:01
@williamjallen williamjallen added this pull request to the merge queue Jan 5, 2026
Merged via the queue into Kitware:master with commit f738e6f Jan 5, 2026
7 checks passed
@williamjallen williamjallen deleted the project-boolean-columns branch January 5, 2026 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants