-
Notifications
You must be signed in to change notification settings - Fork 8
Tests: Merge Uncode Theme Tests #987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WordPress Playground🚀 Your PR has been built and is ready for testing in WordPress Playground! |
noelherrick
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand this correctly, these two tests when ran in parallel would sometimes cause failures since one would remove the theme and then the other one would expect it. If so, I'm curious why merging them would solve it because other tests set the theme.
Honestly, I'm not sure, given the (two) existing tests correctly switch to/from the Uncode theme. I think the Uncode theme isn't the most reliable, and it's not something I particularly want to focus time and resources on, given its limited usage. |
…ock-refreshing` class
Different versions of WordPress will output CSS classes in a different order; therefore seeInSource isn’t reliable. This helper method checks the element’s class attribute for the provided array of classes to check they exist.
… paragraph/paragraph and paragraph, depending on WordPress version
Block Refresh: Use Spinner when `ProgressBar` component unavailable
Form Builder: Set Email Field type = `email`
Update `readme.txt`
Summary
Uncode theme tests were failing due to its reliance on an older version of the Options Tree plugin, which incorrectly assumes get_template() always returns a value. This caused our individual End-to-End tests to break when switching themes or deactivating plugins.
To work around this, the two tests were merged into one, ensuring the theme and plugin state remain consistent during the test. This resolves the failures without modifying Uncode itself.
Testing
Existing tests pass.
Checklist