CMake flag for runtime ICD discovery on Apple machines#1204
Merged
charles-lunarg merged 1 commit intoKhronosGroup:mainfrom Feb 4, 2026
Merged
CMake flag for runtime ICD discovery on Apple machines#1204charles-lunarg merged 1 commit intoKhronosGroup:mainfrom
charles-lunarg merged 1 commit intoKhronosGroup:mainfrom
Conversation
|
Author JarrettSJohnson not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
Author JarrettSJohnson not on autobuild list. Waiting for curator authorization before starting CI build. |
5 tasks
charles-lunarg
approved these changes
Feb 4, 2026
Contributor
charles-lunarg
left a comment
There was a problem hiding this comment.
This is a good solution. vkcube indeed doesn't strictly require bundling a driver on macOS, so making it optional for package builders is the right call.
Thanks for going ahead and making the necessary changes!
|
CI Vulkan-Tools build queued with queue ID 639829. |
|
CI Vulkan-Tools build # 1934 running. |
|
CI Vulkan-Tools build # 1934 passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For context, I'm a package manager for some Vulkan components, and one of them includes this
Vulkan-Tools. One issue I'm currently running into is the build requirement forMoltenVKthat's required forcubeandcubepp. I assume that these could, and perhaps should, be able to be built without it (e.g. if you haveKosmicKrispas your preferred driver and don't have the SDK installed).This PR introduces a CMake flag
APPLE_USE_SYSTEM_ICDthat will rely on the vulkan loader for driver discovery. I kept this flag off by default so that previous behavior would be maintained without any changes to the build workflow. This would be helpful for those who wantscube/ppwithout requiringMoltenVKat build time.