Skip to content

Conversation

@joevanwanzeeleKF
Copy link
Contributor

  • bug fix: _certDataReader is now initialized in the Initialize method

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses a bug where the _certDataReader field was not being initialized in the Initialize method, along with multiple improvements to API response handling, logging, and spelling corrections throughout the codebase. The changes also update package dependencies and refactor how Vault API responses are deserialized by properly handling the wrapped response format.

Key changes:

  • Fixed bug where _certificateDataReader was not initialized in the Initialize method (line 57)
  • Changed RevocationTime from DateTime? to string in CertResponse to properly handle RFC3339 formatted timestamps from Vault API
  • Updated multiple package dependencies to newer versions, including several to version 10.0.0
  • Refactored Vault API calls to use WrappedResponse<T> wrapper for proper deserialization of nested response data
  • Corrected multiple spelling errors ("retreive" → "retrieve", "successfule" → "successful")

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
hashicorp-vault-cagateway/HashicorpVaultCAConnector.cs Initializes _certificateDataReader, adds assembly version logging, changes RevocationTime handling from DateTime to string, fixes spelling errors, adds cancellation token to sync operations
hashicorp-vault-cagateway/Client/VaultHttp.cs Enhanced logging, improved deserialization handling, fixed error message terminology
hashicorp-vault-cagateway/Client/HashicorpVaultClient.cs Refactored to use WrappedResponse wrapper for API calls, fixed spelling in documentation
hashicorp-vault-cagateway/APIProxy/WrappedResponse.cs Added RequestId and MountType properties to match Vault API response structure
hashicorp-vault-cagateway/APIProxy/CertResponse.cs Changed RevocationTime from DateTime? to string, added RevocationTimestamp property
hashicorp-vault-cagateway/hashicorp-vault-caplugin.csproj Updated package versions and added Microsoft.Extensions.Logging.Abstractions, removed Resources configuration
hashicorp-vault-cagateway/Properties/launchSettings.json Removed launch settings file
readme_source.md Fixed spelling error in documentation
CHANGELOG.md Added entry documenting the bug fix

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@indrora indrora merged commit 371b78e into release-1.0 Jan 8, 2026
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants