-
Notifications
You must be signed in to change notification settings - Fork 0
Bug Fix: Initializing _certDataReader #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
joevanwanzeeleKF
commented
Oct 29, 2025
- bug fix: _certDataReader is now initialized in the Initialize method
… version of the integration
…sm for getting product ID's. Added check for a null response.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR addresses a bug where the _certDataReader field was not being initialized in the Initialize method, along with multiple improvements to API response handling, logging, and spelling corrections throughout the codebase. The changes also update package dependencies and refactor how Vault API responses are deserialized by properly handling the wrapped response format.
Key changes:
- Fixed bug where
_certificateDataReaderwas not initialized in the Initialize method (line 57) - Changed
RevocationTimefromDateTime?tostringinCertResponseto properly handle RFC3339 formatted timestamps from Vault API - Updated multiple package dependencies to newer versions, including several to version 10.0.0
- Refactored Vault API calls to use
WrappedResponse<T>wrapper for proper deserialization of nested response data - Corrected multiple spelling errors ("retreive" → "retrieve", "successfule" → "successful")
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| hashicorp-vault-cagateway/HashicorpVaultCAConnector.cs | Initializes _certificateDataReader, adds assembly version logging, changes RevocationTime handling from DateTime to string, fixes spelling errors, adds cancellation token to sync operations |
| hashicorp-vault-cagateway/Client/VaultHttp.cs | Enhanced logging, improved deserialization handling, fixed error message terminology |
| hashicorp-vault-cagateway/Client/HashicorpVaultClient.cs | Refactored to use WrappedResponse wrapper for API calls, fixed spelling in documentation |
| hashicorp-vault-cagateway/APIProxy/WrappedResponse.cs | Added RequestId and MountType properties to match Vault API response structure |
| hashicorp-vault-cagateway/APIProxy/CertResponse.cs | Changed RevocationTime from DateTime? to string, added RevocationTimestamp property |
| hashicorp-vault-cagateway/hashicorp-vault-caplugin.csproj | Updated package versions and added Microsoft.Extensions.Logging.Abstractions, removed Resources configuration |
| hashicorp-vault-cagateway/Properties/launchSettings.json | Removed launch settings file |
| readme_source.md | Fixed spelling error in documentation |
| CHANGELOG.md | Added entry documenting the bug fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.