Skip to content

Update commit_android_version_bump_action.rb #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
raiffeisennet wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update commit_android_version_bump_action.rb #5

raiffeisennet wants to merge 1 commit into from

Conversation

@raiffeisennet
Copy link

@raiffeisennet raiffeisennet commented Feb 12, 2018

Consider also directories with spaces in their name

Update commit_android_version_bump_action.rb
87c16ea 
Consider also directories with spaces in their name
@bbjay bbjay mentioned this pull request Jul 26, 2019
Open
@bbjay
Copy link

bbjay commented Jul 26, 2019

fixes #6

@oklimberg
Copy link
Collaborator

oklimberg commented May 23, 2020

This change will not handle all locations in code, where the project path is used.
Additionally, I prefer using shellescape on the sting.

I will merge the change from commit mceSystems@853ea97 soon.

@oklimberg oklimberg closed this May 23, 2020
@oklimberg oklimberg reopened this May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Geekhole Geekhole Geekhole approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@raiffeisennet @bbjay @oklimberg @Geekhole