forked from CrunchyData/postgres-operator
-
Notifications
You must be signed in to change notification settings - Fork 4
Bugfix/workflow lint error #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gaoxueyu
merged 2 commits into
IvorySQL:master
from
balinorLiang:bugfix/workflow_lint_error
Dec 15, 2025
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,75 +1,62 @@ | ||
| # https://golangci-lint.run/usage/configuration/ | ||
| version: "2" | ||
|
|
||
| linters: | ||
| disable: | ||
| - contextcheck | ||
| - errchkjson | ||
| - gci | ||
| - gofumpt | ||
| - scopelint | ||
| enable: | ||
| - depguard | ||
| - gomodguard | ||
| - gosimple | ||
| - importas | ||
| - misspell | ||
| - unconvert | ||
| presets: | ||
| - bugs | ||
| - format | ||
| - unused | ||
|
|
||
| linters-settings: | ||
| depguard: | ||
| rules: | ||
| everything: | ||
| deny: | ||
| - pkg: io/ioutil | ||
| desc: > | ||
| Use the "io" and "os" packages instead. | ||
| See https://go.dev/doc/go1.16#ioutil | ||
|
|
||
| not-tests: | ||
| files: ['!$test'] | ||
| deny: | ||
| - pkg: net/http/httptest | ||
| desc: Should be used only in tests. | ||
|
|
||
| - pkg: testing/* | ||
| desc: The "testing" packages should be used only in tests. | ||
|
|
||
| - pkg: github.com/ivorysql/ivory-operator/internal/testing/* | ||
| desc: The "internal/testing" packages should be used only in tests. | ||
|
|
||
| exhaustive: | ||
| default-signifies-exhaustive: true | ||
|
|
||
| goimports: | ||
| local-prefixes: github.com/ivorysql/ivory-operator | ||
|
|
||
| gomodguard: | ||
| blocked: | ||
| modules: | ||
| - gopkg.in/yaml.v2: { recommendations: [sigs.k8s.io/yaml] } | ||
| - gopkg.in/yaml.v3: { recommendations: [sigs.k8s.io/yaml] } | ||
| - gotest.tools: { recommendations: [gotest.tools/v3] } | ||
| - k8s.io/kubernetes: | ||
| reason: > | ||
| k8s.io/kubernetes is for managing dependencies of the Kubernetes | ||
| project, i.e. building kubelet and kubeadm. | ||
|
|
||
| importas: | ||
| alias: | ||
| - pkg: k8s.io/api/(\w+)/(v[\w\w]+) | ||
| alias: $1$2 | ||
| - pkg: k8s.io/apimachinery/pkg/apis/(\w+)/(v[\w\d]+) | ||
| alias: $1$2 | ||
| - pkg: k8s.io/apimachinery/pkg/api/errors | ||
| alias: apierrors | ||
| no-unaliased: true | ||
| settings: | ||
| dupword: | ||
| ignore: | ||
| # We might see duplicate instances of 'fi' if we end two bash 'if' statements | ||
| - fi | ||
|
|
||
| depguard: | ||
| rules: | ||
| everything: | ||
| deny: | ||
| - pkg: io/ioutil | ||
| desc: > | ||
| Use the "io" and "os" packages instead. | ||
| See https://go.dev/doc/go1.16#ioutil | ||
| not-tests: | ||
| files: ['!$test'] | ||
| deny: | ||
| - pkg: net/http/httptest | ||
| desc: Should be used only in tests. | ||
| - pkg: testing/* | ||
| desc: The "testing" packages should be used only in tests. | ||
| - pkg: github.com/ivorysql/ivory-operator/internal/testing/* | ||
| desc: The "internal/testing" packages should be used only in tests. | ||
|
|
||
| exhaustive: | ||
| default-signifies-exhaustive: true | ||
|
|
||
| gomodguard: | ||
| blocked: | ||
| modules: | ||
| - gopkg.in/yaml.v2: { recommendations: [sigs.k8s.io/yaml] } | ||
| - gopkg.in/yaml.v3: { recommendations: [sigs.k8s.io/yaml] } | ||
| - gotest.tools: { recommendations: [gotest.tools/v3] } | ||
| - k8s.io/kubernetes: | ||
| reason: > | ||
| k8s.io/kubernetes is for managing dependencies of the Kubernetes project. | ||
|
|
||
| importas: | ||
| alias: | ||
| - pkg: k8s.io/api/(\w+)/(v[\w\w]+) | ||
| alias: $1$2 | ||
| - pkg: k8s.io/apimachinery/pkg/apis/(\w+)/(v[\w\d]+) | ||
| alias: $1$2 | ||
| - pkg: k8s.io/apimachinery/pkg/api/errors | ||
| alias: apierrors | ||
| no-unaliased: true | ||
|
|
||
| run: | ||
| build-tags: | ||
| - envtest | ||
| skip-dirs: | ||
| - pkg/generated | ||
| - envtest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reconsider the linting strategy: suppressions vs. fixes.
The workflow now uses
.golangci.next.yamlwhich enablesstaticcheckandgosec, but the PR adds numerousnolint:staticchecksuppressions throughout the codebase instead of addressing the underlying issues. This defeats the purpose of enabling stricter linters.Recommendation: Either:
The current approach of "enable linter + suppress all warnings" provides no value and makes the codebase harder to maintain.
Based on learnings, addressing linter warnings properly improves code quality and prevents future issues.
🤖 Prompt for AI Agents