[BUG] Missing support exception in ixc when array as type declaration #478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced `NotImplementedException` in `ICombinedThreeVisitor`'s `CreateMergedConfigurations` method with an informational log message. Enhanced `IxNodeVisitor` to log warnings for unsupported array type declarations, including file location when available. Updated `launchSettings.json` to reflect a new working directory path for the `axopen-traversal` configuration.
PTKu
changed the title
Replaced the logging statement in the `CreateMergedConfigurations` method of the `ICombinedThreeVisitor` interface with a `throw new NotImplementedException();`. This change explicitly marks the method as unimplemented, ensuring it raises an exception if invoked.
The test for the `Accept` method no longer asserts that a `NotSupportedException` is thrown. The `Assert.Throws` call was replaced with a direct invocation of the `Accept` method, indicating that the method is no longer expected to throw this exception in the given context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces improved error handling and user feedback for unsupported array type declarations, and updates a project launch setting to reflect a new working directory path.
Error handling and logging improvements:
Acceptmethod forIArrayTypeDeclarationSyntaxinIxNodeVisitor.csnow logs a warning with the filename when array types are declared in unsupported locations, instead of throwing aNotSupportedException. It uses reflection to extract the filename from the syntax node, and gracefully handles any exceptions by logging a generic warning.closes #477