Skip to content

Conversation

@github-actions
Copy link
Contributor

closes #42

@peterbarancek peterbarancek marked this pull request as ready for review October 24, 2025 07:53
Copilot AI review requested due to automatic review settings October 24, 2025 07:53
@peterbarancek peterbarancek merged commit b3f5476 into dev Oct 24, 2025
1 check failed
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug by adding the missing Jerk parameter to movement operations in service view models. The changes also correct inheritance relationships in the Kuka robotics WPF implementation.

  • Adds Jerk parameter synchronization for all axes in single and multi-axis movement operations
  • Fixes incorrect class inheritance in TcoKrc4_Ecat view model classes

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
TcoKrc4_Ecat_v_5_x_xServiceViewModel.cs Corrects TcoKrc4_Ecat_v_5_x_xViewModel to inherit from TcoKrc4_Ecat_v_5_x_xServiceViewModel instead of TcoKrc4_v_5_x_xServiceViewModel
TcoKrc4_ECat_v_5_x_xServiceView.xaml.cs Updates DataContext initialization to use TcoKrc4_Ecat_v_5_x_xServiceViewModel instead of TcoKrc4_v_5_x_xServiceViewModel
TcoSingleAxisServiceViewModel.cs Adds Jerk parameter synchronization in MoveToPosition method for single axis operations
TcoMultiAxisServiceViewModel.cs Adds Jerk parameter synchronization in MoveToPosition method for all four axes (Axis1-4)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

this.Component._axis1._moveAbsoluteTask._jerk.Synchron = SelectedItem.Axis1.Jerk.Synchron;



Copy link

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The Jerk parameter is placed after Deceleration but before the Axis1MoveAllowed check. For consistency with the existing parameter pattern (Position, Velocity, Acceleration, Deceleration), consider moving the blank line 210 to after the Jerk assignment to maintain the same spacing pattern as other parameters.

Suggested change

Copilot uses AI. Check for mistakes.
Comment on lines +181 to 184




Copy link

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The Jerk parameter is placed after Deceleration with an extra blank line. For consistency with the existing parameter pattern (Position, Velocity, Acceleration, Deceleration), consider removing the blank line 181 to maintain the same spacing as the parameters above.

Suggested change

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]Add Jerk parameter to movement in service

1 participant