[Fix] port already in use occured occasionally
#1425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. refactor find_master_addr_and_port, set sock option socket.SO_REUSEADDR to socket
YanhuiDua
reviewed
Jan 15, 2026
xtuner/v1/ray/utils.py
Outdated
| s.close() | ||
| else: | ||
| assert isinstance(start_port, int) | ||
| assert isinstance(end_port, int) |
Collaborator
There was a problem hiding this comment.
有没有一种情况是：start_port is not None, end_port is None 呢？
Collaborator
There was a problem hiding this comment.
如果不允许start_port is not None, end_port is None的话，这里也要检查下(end_port - start_port) > nums
YanhuiDua
reviewed
Jan 15, 2026
xtuner/v1/ray/utils.py
Outdated
| if start_port is None: | ||
| for _ in range(nums): | ||
| s = socket.socket(socket.AF_INET, socket.SOCK_STREAM) | ||
| # socket.SO_REUSEADDR can help avoid TIME_WAIT state issues |
Collaborator
There was a problem hiding this comment.
socket.SO_REUSEADDR can help to bind the port in TIME_WAIT state immediately
1. Add more detailed comment on socket.SO_REUSEADDR 2. Add assert message in the case of start_port is not None
YanhuiDua
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In current CI rollout unittest, OSError
port already in useoccured occasionally. After several attempts, we found the main cause of this error is port tested infind_master_addr_and_portmay not be freed after the funciton call. We can usesocket.SO_REUSEADDRoption to make the port available.Key Change: