Skip to content

[Feature] Optimizing the communication of FSDP through NVLink SHARP and IBGDA #1415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HIT-cwh wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Feature] Optimizing the communication of FSDP through NVLink SHARP and IBGDA #1415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e24237
[Feature] support custom fsdp agrs for pt2.8
HIT-cwh Jan 4, 2026
067f8e3
[Feature] support custom fsdp agrs for pt2.6
HIT-cwh Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion xtuner/v1/patch/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from . import torch_shape_env_simplify_pt28
from .torch_dcp_planner import patch_default_save_plan
from .torch_fsdp_comm import patch_fsdp_agrs


__all__ = ["patch_default_save_plan", "torch_shape_env_simplify_pt28"]
__all__ = ["patch_default_save_plan", "torch_shape_env_simplify_pt28", "patch_fsdp_agrs"]
Comment on lines +3 to +6
Copy link

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function name 'patch_fsdp_agrs' contains a typo. It should be 'patch_fsdp_args' (with 'args' instead of 'agrs'). This needs to be updated in both the import and export to match the corrected function name.

Copilot uses AI. Check for mistakes.
Loading
Loading