Skip to content

Upgrade template 1.4.0->2.0.2#157

Draft
mzweilin wants to merge 24 commits intomainfrom
upgrade_template_2.0.2
Draft

Upgrade template 1.4.0->2.0.2#157
mzweilin wants to merge 24 commits intomainfrom
upgrade_template_2.0.2

Conversation

@mzweilin
Copy link
Contributor

@mzweilin mzweilin commented Jun 6, 2023 •
edited
Loading

What does this PR do?

Upgrade to the latest template 2.0.2 at https://github.com/ashleve/lightning-hydra-template

Changes

  • upgrade to hydra 1.3
  • upgrade toolkits in pre-commit
  • config datamodule -> data
  • add a cpu trainer config
  • move src.tasks to src
  • stop exporting extra log after a task exception.
  • split src.utils.utils into several .py files
  • add aim as a logger
  • update .gitignore for the aim logger

Already included (or with newer versions) in #192

  • torch ~= 1.13.1 -> torch ~= 2.0.1
  • pytorch-lightning ~= 1.6.5 -> lightning ~= 2.0.2
  • torchmetrics == 0.6.0 -> torchmetrics == 0.11.4 (newer PL requires torchmetrics>0.6.0)
  • use lightning.fabric for TPU

[Resolved] The PR depends on Lightning-AI/torchmetrics#1024
We won't upgrade torchmetrics until they fix mAP.

Type of change

Please check all relevant options.

  • Improvement (non-breaking)
  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing

Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.

  • pytest

Before submitting

  • The title is self-explanatory and the description concisely explains the PR
  • My PR does only one thing, instead of bundling different changes together
  • I list all the breaking changes introduced by this pull request
  • I have commented my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have run pre-commit hooks with pre-commit run -a command without errors

Did you have fun?

Make sure you had fun coding 🙃

dependabot bot and others added 19 commits May 9, 2023 16:04
@dependabot
Update torch requirement from ~=1.13.1 to ~=2.0.1
38313bc 
---
updated-dependencies:
- dependency-name: torch
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@mzweilin
Update to a newer torchvision that matches torch 2.0.1.
4faa318
@mzweilin
Upgrade pytorch-lightning and torchmetrics.
9df5f52
@mzweilin
Merge branch 'main' into dependabot/pip/torch-approx-eq-2.0.1
ccd5406
@mzweilin
Update pre-commit.
098daf8
@mzweilin
datamodule->data
05bbf0d
@mzweilin
Add data.num_classes for the Accuracy metric of classification.
395692d
@mzweilin
datamodule->data extra.
4c7c04b
@mzweilin
pytorch_lightning->lightning.pytorch
a0ba7ba
@mzweilin
Hydra 1.2->1.3
ff114a1
@mzweilin
Split utils.
b5bdf31
@mzweilin
Update to PL's new API.
31145b7
@mzweilin
Add aim logger.
03d4c47
@mzweilin
Add cpu trainer.
a29a317
@mzweilin
Fix paths of lightning.pytorch and mart.data.
27cbe96
@mzweilin
Update comment.
5597103
@mzweilin
Dependency: pytorch_lightning -> lightning
5eec5e3
@mzweilin
Update to new API of mAP in torchmetrics.
1c83e34
@mzweilin
Fix path of pytorch_lightning -> lightning.pytorch.
cbd2fcf
@mzweilin mzweilin marked this pull request as draft June 6, 2023 00:24
@mzweilin mzweilin mentioned this pull request Jun 22, 2023
Merged
16 tasks
@dxoigmn
Copy link
Member

dxoigmn commented Jun 22, 2023 •
edited
Loading

I should note that it looks like torchmetrics 1.0 will be released soon and that will re-include the mAP implementation that uses cocoapi. See: https://github.com/Lightning-AI/torchmetrics/milestone/13

@dxoigmn
Copy link
Member

dxoigmn commented Jul 5, 2023

torchmetrics 1.0 has been released! Upgrade all the dependencies!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mzweilin @dxoigmn