Skip to content

Conversation

@martyngigg
Copy link
Contributor

@martyngigg martyngigg commented Dec 19, 2025

Summary

Requiring docker is quite heavy for pre-commit. Move to non-docker base solutions.

  • Move shellcheck to Python-based version.
  • markdownlint-cli2 now needs node but is lighter weight.

Summary by CodeRabbit

  • Chores
    • Updated CI workflow configuration for static analysis checks with alternative Ubuntu infrastructure
    • Updated shellcheck pre-commit hook with new repository source and revised version
    • Migrated markdownlint pre-commit hook from Docker-based implementation to standard variant

✏️ Tip: You can customize this high-level summary in your review settings.

Move shellcheck to Python-based version.
markdownlint-cli2 now needs node but is lighter weight.
@coderabbitai
Copy link

coderabbitai bot commented Dec 19, 2025

Walkthrough

The pull request modifies CI and pre-commit configurations. The staticcheck CI job runner changed from ubuntu-latest to ubuntu-slim. The pre-commit configuration updates shellcheck to use shellcheck-py/shellcheck-py with revision v0.11.0.1 and switches markdownlint from Docker-based to plain variant.

Changes

Cohort / File(s) Summary
CI Workflow Configuration
\.github/workflows/ci-static.yml
Updated staticcheck job runner from ubuntu-latest to ubuntu-slim
Pre-commit Hooks Configuration
\.pre-commit-config.yaml
Replaced shellcheck repository from koalaman/shellcheck-precommit to shellcheck-py/shellcheck-py with revision v0.11.0.1; switched markdownlint from Docker-based variant to plain variant

Poem

🐰 A slimmer workflow hops with glee,
Shellcheck finds its destiny,
Docker fades, plain tools emerge,
Pre-commit magic at the verge! ✨

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main objective of the pull request—removing Docker requirements from pre-commit hooks by switching to non-Docker alternatives (Python-based shellcheck and non-Docker markdownlint).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 8112d6e and 04b70f8.

📒 Files selected for processing (2)
  • .github/workflows/ci-static.yml (1 hunks)
  • .pre-commit-config.yaml (1 hunks)
🔇 Additional comments (3)
.pre-commit-config.yaml (2)

19-20: Change to shellcheck-py is approved.

The shellcheck-py repository is a Python wrapper that provides a pip-installable shellcheck binary, downloading the pre-built shellcheck binary for your particular platform. Version v0.11.0.1 is the latest release and is healthy with no known security issues. The configuration is correct and aligns with the PR objective of removing Docker dependencies.


26-26: Switch from Docker to Node.js-based markdownlint hook approved.

The change to the non-Docker variant markdownlint-cli2 correctly removes the Docker dependency. Pre-commit automatically handles Node.js for this hook, though you may need to override the Node.js version depending on your environment.

.github/workflows/ci-static.yml (1)

13-13: ubuntu-slim is a valid GitHub Actions runner type.

ubuntu-slim is an official GitHub-hosted runner label that offers a lower-cost, single-CPU option for running lightweight operations. These runners have one vCPU and 5 GB RAM, and your actions workflows execute inside of a container rather than a dedicated VM instance, enabling cost-effective execution. The job timeout for single-CPU runners is 15 minutes, and jobs exceeding this limit will be terminated and fail. This is an appropriate choice for your workflow if your static checks are lightweight operations.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@martyngigg martyngigg merged commit dae74ba into main Dec 19, 2025
1 of 2 checks passed
@martyngigg martyngigg deleted the drop-docker-from-pre-commit-hooks branch December 19, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants