Skip to content

CoDICE lo counters single inst_az_label fix #2527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lacoak21 merged 1 commit into from
Dec 22, 2025
Merged

CoDICE lo counters single inst_az_label fix #2527

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion imap_processing/codice/codice_l1a_lo_counters_singles.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ def l1a_lo_counters_singles(unpacked_dataset: xr.Dataset, lut_file: Path) -> xr.
attrs=cdf_attrs.get_variable_attributes("inst_az", check_schema=False),
),
"inst_az_label": xr.DataArray(
np.arange(inst_az, dtype=np.uint8).astype(str),
(np.arange(inst_az, dtype=np.uint8) + 1).astype(str),
Copy link
Collaborator

@greglucas greglucas Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this might get confusing why the label is different from the values? Do they want the inst_az values being 0-based indices but the labels being 1-based, or instead should they both be 1-based?

Copy link
Contributor Author

@lacoak21 lacoak21 Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The positions themselves are zero based but they are referred to / known as 1 based.. I know that is confusing but I brought this up in the CoDICE tag up this morning and Micael confirmed that this was the desired label.

dims=("inst_az",),
attrs=cdf_attrs.get_variable_attributes(
"inst_az_label", check_schema=False
Expand Down