Skip to content

Conversation

@dallan-keylogic
Copy link
Contributor

@dallan-keylogic dallan-keylogic commented Nov 18, 2025

Fix notebook for new block triangularization

The PR IDAES/idaes-pse#1704 changes how the BlockTriangularizationInitializer works, which results in a unit model in the custom unit model notebook raising an exception. This exception is the result of problems in the unit model that are then diagnosed with the Diagnostics Toolbox. In order to avoid test failures, we wrap the initialization in a try/except block.


Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

📚 Documentation preview 📚: https://idaes-examples--157.org.readthedocs.build/en/157/

@dallan-keylogic dallan-keylogic marked this pull request as ready for review November 18, 2025 17:59
Copy link
Contributor

@bpaul4 bpaul4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Downloaded and compared changes with version on main. I agree with the changes.

@dallan-keylogic dallan-keylogic merged commit 9a487fc into IDAES:main Nov 19, 2025
22 checks passed
@dallan-keylogic dallan-keylogic deleted the bt_fix branch November 19, 2025 14:55
@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority:High High Priority Issue or PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants