Skip to content

Fix SOC dynamics failure #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dallan-keylogic merged 39 commits into from
Oct 30, 2025
Merged

Fix SOC dynamics failure #150

dallan-keylogic merged 39 commits into from
Oct 30, 2025

Conversation

@dallan-keylogic
Copy link
Contributor

@dallan-keylogic dallan-keylogic commented Sep 22, 2025 •
edited
Loading

Summary/Motivation:

  • Fixes the failing tests in notebooks/docs/power_gen/solid_oxide_cell/soc_pid_control_test.ipynb in Additional SOC Updates idaes-pse#1667. Note that that PR should be merged before this one.
  • Updates the SOC flowsheet to allow for a heat loss term and user-specified discretization of the SOC in the z direction.

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

dallan-keylogic and others added 30 commits March 26, 2024 13:48
@dallan-keylogic
New notebook soc_pid_con in directory docs/power_gen/solid_oxide_cell
0e7b721
@dallan-keylogic
Preliminary work on getting notebook ready.
96ed166
@dallan-keylogic
bring pid example up to date
b66dd6a
@dallan-keylogic
remember to save
b04811a
@dallan-keylogic
do preprocessing
16ab864
@dallan-keylogic
add soc_dynamic_flowsheet.svg to gitignore
5249cbc
@dallan-keylogic
make gitignore and checking results work
aa7da92
@dallan-keylogic
delete wrong flowsheet
27ea1f4
@dallan-keylogic
update initial conditions
1297af2
@dallan-keylogic
delete irrelevant file
611f466
@dallan-keylogic
update to merged crossflow_hx nomenclature
b2f91a0
@dallan-keylogic
run idaesx pre
643066a
@dallan-keylogic
New notebook soc_steady_state_optimiza in directory docs/power_gen/so…
a5e56cb 
…lid_oxide_cell
@lbianchi-lbl
Merge branch 'main' into soc-flowsheet
64cb001
@dallan-keylogic
steady state optimization
5a8faea
@dallan-keylogic
Merge branch 'soc-flowsheet' into soc-optimization
d673318
@dallan-keylogic
changes
c35eec9
@dallan-keylogic
new setpoint files
bb6c43b
@dallan-keylogic
changes
7749c48
@dallan-keylogic
Merge branch 'soc-flowsheet' into soc-optimization
58b9be2
@dallan-keylogic
merge
73ef5b1
@dallan-keylogic
fixes
aa1aae8
@dallan-keylogic
optimization
e14a3b8
@dallan-keylogic
experiments
88456f3
@dallan-keylogic
merge
1d304c7
@dallan-keylogic
merge cleanup
7311b26
@dallan-keylogic
lower expectations
4b6b302
@dallan-keylogic
blah
b054c43
@dallan-keylogic
bring in line with main
a169f88
@dallan-keylogic
changes due to xflowhx fix
d87da6f
@dallan-keylogic dallan-keylogic mentioned this pull request Sep 22, 2025
Merged
@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Sep 25, 2025
@dallan-keylogic dallan-keylogic mentioned this pull request Oct 20, 2025
Closed
@ksbeattie
Copy link
Member

ksbeattie commented Oct 30, 2025

@Ryan-Hughes-8 will review this.

NishantGiridhar
NishantGiridhar approved these changes Oct 30, 2025
View reviewed changes
Copy link

@NishantGiridhar NishantGiridhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Ryan-Hughes-8
Ryan-Hughes-8 approved these changes Oct 30, 2025
View reviewed changes
Copy link

@Ryan-Hughes-8 Ryan-Hughes-8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dallan-keylogic dallan-keylogic merged commit 3e34582 into IDAES:main Oct 30, 2025
11 checks passed
@dallan-keylogic dallan-keylogic mentioned this pull request Oct 30, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ryan-Hughes-8 Ryan-Hughes-8 Ryan-Hughes-8 approved these changes

@NishantGiridhar NishantGiridhar NishantGiridhar approved these changes

@jinliangma jinliangma Awaiting requested review from jinliangma

Assignees

@dallan-keylogic dallan-keylogic

Labels

Priority:Normal Normal Priority Issue or PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dallan-keylogic @ksbeattie @Ryan-Hughes-8 @NishantGiridhar @lbianchi-lbl