Skip to content

Conversation

@tannerpolley
Copy link

@tannerpolley tannerpolley commented Jun 18, 2025

(From #143)

For the Flash Unit Model tutorial, changes include:

  • Update to initialization
  • Added scaling features for some variables
  • Revised some language
  • Improved overall structure and flow
    • Many other small changes

For the HDA Flowsheet Tutorial, changed include:

  • Added Feed and Product unit models to improve the readability of the stream reports and align with current flowsheet standards
  • Added full manual flowsheet initialization tutorial
  • Added a AutoScaler method for a basic scaling step
  • Revised overall structure and readability of many sections
  • Many other small changes

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

📚 Documentation preview 📚: https://idaes-examples--144.org.readthedocs.build/en/144/

@dallan-keylogic
Copy link
Contributor

dallan-keylogic commented Aug 7, 2025

This PR is waiting on IDAES/idaes-pse#1643

ksbeattie and others added 3 commits August 21, 2025 11:20
empty change to trigger github actions
…itialized the HDA flowsheet files to work with the modular properties framework. Currently not working due to unit model initialization error.
@dallan-keylogic
Copy link
Contributor

Now waiting on IDAES/idaes-pse#1646 , but also we might want to use a different set of state variables, FpcTP has issues with degeneracy when a phase disappears.

@ksbeattie
Copy link
Member

@tannerpolley do you have time to look into this, perhaps restarting with a new PR?

@ksbeattie
Copy link
Member

@tannerpolley, pushing this to Feb '26 release as progress appears stalled.

@tannerpolley
Copy link
Author

@ksbeattie @dallan-keylogic I just finished updating the HDA Flowsheet again with the new state definition but I ran build again and the same error occurred with the distorted HTML page. I can also just restart with a new PR if thats easier

@ksbeattie
Copy link
Member

@ksbeattie @dallan-keylogic I just finished updating the HDA Flowsheet again with the new state definition but I ran build again and the same error occurred with the distorted HTML page. I can also just restart with a new PR if thats easier

Thanks @tannerpolley, whatever is easier for you is fine.

… the necessary supporting files to make it work. Included a Python file of the flowsheet.
@ksbeattie
Copy link
Member

@tannerpolley, I'm moving this back to "In Progress" since there are conflicts to resolve. You can take the incoming changes for the conflicts in core.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority:High High Priority Issue or PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants