You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Little update on this stale PR: I'll clean up the Mac implementation of *isFront this week & get it PR'd, either reusing this one or opening a new one.
The README update in this PR should also be amended to list bringToFront in the large table of implemented features, that way we can callout the missing X11 implementation.
For some reason, using a local JWM version with publicly released bringToFront code (see merged #269) is failing to correctly steal focus in Mac. The code runs but simply fails to steal focus -- calls to isFront afterwards always returns false. Perhaps this is a permissions issue that the local build works around?
I'm not sure yet but I'll need to PR bringToFront once I figure out a fix. In the meantime, I'm going to close this PR & bundle it into #286 to reduce PR churn.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usually I'd bundle this into another PR but the MacOS implementation of
bringToFrontis ugly and might take a few weeks to land.