Skip to content

Conversation

@JM00oo
Copy link

@JM00oo JM00oo commented Dec 9, 2016

Add lbs v2 feature. @bbhands

@JM00oo JM00oo force-pushed the feature/lbs-v2/item branch 2 times, most recently from 20d6a69 to e98d254 Compare December 22, 2016 08:12
@JM00oo JM00oo force-pushed the feature/lbs-v2/item branch from 7f14d74 to 21235d6 Compare December 22, 2016 08:16
Copy link
Member

@bbhands bbhands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LBS model的部份感覺上移到core/loadbalancer下面好像比較整齊一點

return callback(new Error('Malformed API Response'));
}
return err
? callback(err)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

這個再判斷一次err好像是重複做了?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants