Add back button on game screen pre-match #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wennyyustalim
requested review from
MangoSwirl and
alouch1234
and removed request for
alouch1234
(fixes start match button not working after you go back)
alouch1234
previously approved these changes
Jan 12, 2025
MangoSwirl
previously approved these changes
Jan 12, 2025
MangoSwirl
changed the title
MangoSwirl
requested changes
Jan 15, 2025
| {router.canGoBack() && ( | ||
| <TouchableOpacity | ||
| onPress={() => { | ||
| reportState.reset(); |
Member
There was a problem hiding this comment.
This doesn't run on all methods the user could use to go back. There might be accessibility gestures or something, or at least on web (which I know we don't use) you can press the back button in the browser.
I'd recommend using a 'beforeRemove' event to handle all cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this what #19 is asking for?