[tests] Fix cppia inheritance test #1272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Seems like it worked fine with 4.3.7 but there was a regression at some point in haxe development. UPDATE: Seems like it's caused by: HaxeFoundation/haxe#12377 |
tobil4sk
force-pushed
the
run-cppia-inheritance-test
branch
from
7fdffb3 to
34bcc83
Compare
tobil4sk
force-pushed
the
run-cppia-inheritance-test
branch
from
34bcc83 to
1b80062
Compare
Member
Author
|
@Simn This is the final one in the series of cppia override PRs. This test should have caught the regression fixed by #1273 and HaxeFoundation/haxe#12413. However, the client/host hierarchy wasn't set up correctly, so the test passed despite the regression. This PR fixes it so the correct classes are included in the host, which means the test will fail as expected if there is ever a future regression (for example, it was failing with unpatched haxe 5 nightly). @Aidan63 just to let you know as well, since this was a test you added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test wasn't running because it is only enabled for haxe >= 4.3.7 and we were on haxe 4.3.4, and also it wasn't running properly because HostExtendedRoot was not part of the host. See: #1154 (comment)