Skip to content

BuildTool: Fix xcodebuild: error: SDK macosx26 cannot be located. #1260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joshtynjala wants to merge 1 commit into
base: master
Choose a base branch
from
+24 −2
Open

BuildTool: Fix xcodebuild: error: SDK macosx26 cannot be located. #1260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 24 additions & 2 deletions tools/hxcpp/BuildTool.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2203,10 +2203,32 @@ class BuildTool
if (extract_version.match(file))
{
var ver = extract_version.matched(1);
var split_best = best.split(".");
var split_ver = ver.split(".");
if (Std.parseFloat(split_ver[0]) > Std.parseFloat(split_best[0]) || Std.parseFloat(split_ver[1]) > Std.parseFloat(split_best[1]))
var major_ver = Std.parseFloat(split_ver[0]);
var minor_ver = Std.parseFloat(split_ver[1]);
if (Math.isNaN(major_ver) || Math.isNaN(minor_ver))
{
// if version is the wrong format, skip it
continue;
}
var split_best = best.split(".");
var major_best = Std.parseFloat(split_best[0]);
var minor_best = Std.parseFloat(split_best[1]);
if (Math.isNaN(major_best) || Math.isNaN(minor_best))
{
// shouldn't happen, but just to be safe
best = ver;
}
else if (major_ver > major_best)
{
// prefer higher major version
best = ver;
}
else if (major_ver == major_best && minor_ver > minor_best)
{
// if major versions are equal, prefer higher minor version
best = ver;
}
}
}
if (best!="0.0")
Expand Down
Loading