Adding config-style definitions for ion species properties#109
Adding config-style definitions for ion species properties#109
Conversation
|
Ah sorry @marwahaha ; didn't mean to tag you as a reviewer; it was a fat-finger, and it doesn't seem like I can remove you. Feel free to review or not review as you please. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #109 +/- ##
========================================
+ Coverage 83.5% 88.8% +5.4%
========================================
Files 15 13 -2
Lines 1488 1270 -218
========================================
- Hits 1242 1128 -114
+ Misses 246 142 -104
... and 7 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
Have some convenient shorthand for |
I think this is ready to merge once this is done. |
Summary:
IonInstanceclass. We now directly instantiateIonIonPropertiesand config file functions to their own file, as it felt likeions.jlwas getting too big.