Skip to content

Conversation

@wlcx
Copy link

@wlcx wlcx commented Jun 13, 2024

requestVideoFrameCallback isn't available in !chrome currently, so add a polyfill

@rrah
Copy link

rrah commented Jun 13, 2024

The current box only seems to update when the video is playing - so if you step through frame-by-frame or jump to a specific timecode, current stays at the value of when you stopped

@wlcx
Copy link
Author

wlcx commented Jun 15, 2024

Good point. Have added a seeked listener which seems to be good enough?

@rrah
Copy link

rrah commented Jun 15, 2024

Just noticed the current time also appears to be one frame off. Marking an in or out is accurate, but current is consistently 1 frame ahead. Can't figure out where its coming from tho

@wlcx
Copy link
Author

wlcx commented Jun 15, 2024

@rrah so I generated a test video (only at 25p admittedly) with BITC, and I noticed the converted video seemed to have 1 extra frame on the end. otherwise it seemed pretty much bang on to me

@rrah
Copy link

rrah commented Jun 15, 2024

At least for me, if I load a video, Current starts at 00:00:00:01. If I mark an In or Out, it's recorded as 00:00:00:00, but with Current still being 00:00:00:01
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants