-
Notifications
You must be signed in to change notification settings - Fork 1
Move interaction form into a modal. #264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the interactions feature by moving the add interaction form into a modal and adding edit functionality. The changes consolidate the UI into a modal-based workflow similar to the strikes and tests components.
- Introduces
InteractionDetailsModalfor both adding and editing interactions - Adds edit capability with a new
useEditInteractionhook integration - Adds edit button to each interaction in the list
- Removes the inline
AddNewInteractionComponentin favor of modal-based interaction
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 12 comments.
| File | Description |
|---|---|
| client/src/components/interactions/InteractionsList.tsx | Added edit button and onClickEdit callback prop to enable editing interactions from the list |
| client/src/components/interactions/InteractionsInfo.tsx | Replaced inline form with modal-based workflow, integrated edit functionality, but contains unused delete-related code that should be removed |
Comments suppressed due to low confidence (1)
client/src/components/interactions/InteractionsInfo.tsx:25
- Unused variable setIdToDelete.
const [idToDelete, setIdToDelete] = useState<string>('');
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Formatted with prettier
Description:
This adds a modal for interactions. Editing interactions is also made possible.
This combines existing interactions components and uses the new editing interaction hook.