Skip to content

Conversation

@AhmadSaadeddin1987
Copy link

Fetch APIS from the backend and make test

@AhmadSaadeddin1987
Copy link
Author

@RHSebregts

Copy link

@RHSebregts RHSebregts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I think this all works nicely, good job. Please make sure you use the proper indentation, this really makes code soo much easier to read (and write also!). If you need help setting that up, or want a refresher on indentation, feel free to reach out!
On a similar note, using empty lines to space out your code is always a nice visual aid as well.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NEVER EVER EVER UPLOAD YOUR API KEYS!!!!!!!!!! Instead put them either in an .env file, or use them as runtime arguments (API_KEY=123245 node server.js and then process.env.API_KEY in code)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did it and add the last modification commit, it is very useful feedback because i made a big error with sharing my API_key

@AhmadSaadeddin1987
Copy link
Author

Hi, I think this all works nicely, good job. Please make sure you use the proper indentat
Thank u so much i use Prettier to make the code easier to read

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants