-
Notifications
You must be signed in to change notification settings - Fork 10
Ahmad-w2-nodejs #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Ahmad-w2-nodejs #11
Conversation
RHSebregts
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I think this all works nicely, good job. Please make sure you use the proper indentation, this really makes code soo much easier to read (and write also!). If you need help setting that up, or want a refresher on indentation, feel free to reach out!
On a similar note, using empty lines to space out your code is always a nice visual aid as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NEVER EVER EVER UPLOAD YOUR API KEYS!!!!!!!!!! Instead put them either in an .env file, or use them as runtime arguments (API_KEY=123245 node server.js and then process.env.API_KEY in code)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did it and add the last modification commit, it is very useful feedback because i made a big error with sharing my API_key
|
Fetch APIS from the backend and make test