-
Notifications
You must be signed in to change notification settings - Fork 0
Adding a new XRISM-Xtend getting started notebook #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DavidT3
wants to merge
225
commits into
main
Choose a base branch
from
notebook/newGettingStartedXRISMXtend
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he template, as well as the necessary index entries. For issue #128
…ing-started-xrism-xtend.md. For issue #128
…ef introduction to the xtdpipeline, and a note about the relatively immature nature of XRISM's software and best practises. For issue #128
…the call to it, and the setting up of template file paths. For issue #128
…the getting-started-xrism-xtend.md notebook. For issue #128
…dpipeline in the getting-started-xrism-xtend.md. For issue #128
…ting-started-xrism-xtend.md. Also put in subsection heading for the 'generating new products' part. For issue #128
… gets angry if the outdir already exists, and I like to make sure my demos move INTO the out directory to work. As such there is a lower layer temporary outdir created which is where xtdpipeline can write files. All in getting-started-xrism-xtend.md. For issue #128
…y, as well as a demonstration of how to validate our assumed relation through looking at a pre-generated RMF. All in getting-started-xrism-xtend.md, for issue #128
… required for generating energy bound data products for XRISM-Xtend to the getting-started-xrism-xtend.md notebook. For issue #128
…nd images (gen_xrism_xtend_image) to the getting-started-xrism-xtend.md notebook. For issue #128
… make the image generation work. For issue #128
…-xtend.md notebook, and included some commentary. May add a bit about how to use an event list to find the size of the event pixels. For issue #128
…eration to the getting-started-xrism-xtend.md. For issue #128
…ion in the getting-started-xrism-xtend.md notebook. Seems to work fine, including spatial re-binning and creating different types of map. For issue #128
…tting-started-xrism-xtend.md notebook. For issue #128
…on to the getting-started-xrism-xtend.md notebook, for issue #128
…unction in the getting-started-xrism-xtend.md notebook. For issue #128
…tcurve, to control which light curve bins are thrown out because of fractional exposure. For issue #128
…second section of product generation (with spectra, as it will be source specific). Added a template variable for light curve outputs. All in getting-started-xrism-xtend.md, for issue #128
…getting-started-xrism-xtend.md notebook. Also indicated that N132D can be treated as a point source here, and extended source analysis will be handled in another notebook. For issue #128
…gion file to getting-started-xrism-xtend.md. For issue #128
…es source and background RA-DEC region files. They will be converted to sky coords for each observation, and possibly overlaid on every image from each observation. For issue #128
…ghtcurve' wrapper function for XRISM-Xtend light curve generation in the getting-started-xrism-xtend.md notebook. For issue #128
…ges from XRISM-Xtend data in the getting-started-xrism-xtend.md notebook. If those arguments are missing it seems that no sky-pixel WCS is written to the resulting images, which is obviously a problem. For issue #128
…arted-xrism-xtend.md notebook. Implemented for the light curve generation step at the moment. For issue #128
… getting-started-xrism-xtend.md notebook. For issue #128
…getting-started-xrism-xtend.md notebook. For issue #128.
… generates new spectra which calculates correct values of BACKSCAL for the source and background spectra. For issue #128
…for CALDB access. For issue #128
…e getting-started-xrism-xtend.md notebook. To maybe have it build on CI/CD? For PR #150
…asks into relative paths, to save on string length and the problems it can cause in HEASoft. In getting-started-xrism-xtend.md, for PR #150
…e HEASARC website is a little happier today). For PR #150
…xrism-xtend.md notebook
…ck at some point though
…tend' into notebook/newGettingStartedXRISMXtend
…peed testing purposes.
Collaborator
Author
|
@heasarc-notebooks:mission_specific_tutorials/xrism/getting-started-xrism-xtend.md |
…er a CircleCI run. In getting-started-xrism-xtend.md. For PR #150
Collaborator
Author
|
@heasarc-notebooks:mission_specific_analyses/xrism/getting-started-xrism-xtend.md |
…M-Xtend notebook. For PR #150
Collaborator
Author
|
Image with regions overlaid is not accessible for people who are fully color blind - need to fix that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
doc-content
Changes or additions to the content of the documentation
mission-specific
Issues that relate to a single high-energy mission
ready-for-review
HEASARC internal review process can begin
waiting-on-external
For an issue that may not be solvable until some external software or resource is fixed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HEASARC notebook review template
Critical review criteria
The author of the pull request should make an effort to go through these check points and ensure that their submission satisfies each point - reviewers will also compare to these checklists.
Science review checklist
Formatting checklist
Tech review checklist
try/exceptstatements that are narrow in scope?