Conversation
hsds/datanode_lib.py
Outdated
| if pending_s3_write[obj_id] != now: | ||
| msg = "pending_s3_write timestamp got updated unexpectedly " | ||
| msg += f"for {obj_id}" | ||
| msg = f"pending_s3_write timestamp for got updated unexpectedly for {obj_id}" |
There was a problem hiding this comment.
Typo in the error message: "pending_s3_write timestamp for got updated unexpectedly for {obj_id}" seems to have an extra or misplaced 'for'. Consider revising it, e.g., "pending_s3_write timestamp got updated unexpectedly for {obj_id}".
Suggested change
| msg = f"pending_s3_write timestamp for got updated unexpectedly for {obj_id}" | |
| msg = f"pending_s3_write timestamp got updated unexpectedly for {obj_id}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-raising Cancelled exceptions based on this guidance:
https://docs.python.org/3.8/library/asyncio-exceptions.html#asyncio.CancelledError
Important
Re-raise
CancelledErrorexceptions and improve logging and node management in HSDS.CancelledErrorinstead of converting toHTTPInternalServerErrorinazureBlobClient.pyandfileClient.py.warntoinfofor certain messages inazureBlobClient.pyandfileClient.py.datanode_lib.py.active_sn_idsandactive_dn_idsmanagement inheadnode.pyfor better node tracking.isClusterReady()andregister()inheadnode.pyto use active node lists.headnode.py.getNodeUrls()function inheadnode.pyfor URL management.This description was created by
for 5803e48. You can customize this summary. It will automatically update as commits are pushed.