Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Since we now depend on hdf5-json to do this testing, it might be a good idea to include hdf5-json's tests as a step in the CI
mattjala
left a comment
mattjala
left a comment
There was a problem hiding this comment.
Besides a few minor comments and questions, this is good to go in. I'll try to get the outstanding PRs on hdf5-json reviewed this week so that we can avoid having HSDS depend on a specific branch.
hsds/group_sn.py
Outdated
| created = link_item["created"] | ||
| # allow "pre-dated" attributes if recent enough | ||
| predate_max_time = config.get("predate_max_time", default=10.0) | ||
| if now - created > predate_max_time: |
There was a problem hiding this comment.
This comparison seems backwards. If I understand correctly, the difference between current time and creation time should need to be under the max time, not above it
|
@jreadey Linter issues are preventing CI from running on this right now |
|
@jreadey Should we mark this as draft until it's in a final state for review? |
3 participants
Use h5json package for typing and objids