Closed
Conversation
Author
|
I would like to get a CI running before submitting this PR (see #201). |
byrnHDF
approved these changes
Sep 14, 2025
Author
|
OK, approve my workflow runs and we'll see how the CI likes these changes... |
|
I can verify that after this change, the lz4 plugin seems to write valid data, but is broken before this. |
Contributor
|
@bmaranville Can you explain more in what way was this plugin broken before? And when was before? Until the changes in this PR? |
|
Sorry - I was mistaken. The fix seems to be somewhere between version |
Contributor
|
Thanks for checking. |
Open
Contributor
|
I am closing this pull request because the LZ4 filter plugin's input argument ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for the LZ4 plugin. Fixes #200
Important
Fix and optimize LZ4 plugin by removing
statickeyword, initializingblockSize, usingLZ4_compress_fast, and commenting out debug prints inH5Z_filter_lz4.statickeyword fromH5Z_filter_lz4declaration and definition inH5Zlz4.c.blockSizetoDEFAULT_BLOCK_SIZEin forward filter path.LZ4_compress_fastinstead ofLZ4_compress_defaultinH5Z_filter_lz4.printfstatements inH5Z_filter_lz4for decompression size mismatch and block size information.This description was created by
for bcb40e0. You can customize this summary. It will automatically update as commits are pushed.