Fix CMake config file install paths to follow platform conventions#6174
Draft
lrknox wants to merge 2 commits intoHDFGroup:developfrom
Draft
Fix CMake config file install paths to follow platform conventions#6174lrknox wants to merge 2 commits intoHDFGroup:developfrom
lrknox wants to merge 2 commits intoHDFGroup:developfrom
Conversation
Update HDF_DIR_PATHS macro to install hdf5-config.cmake and related files to platform-appropriate locations: - Windows (not Cygwin): <prefix>/cmake/ - Linux/Unix/Cygwin: <prefix>/<lib_dir>/cmake/hdf5/ - macOS Frameworks: <framework_prefix>/hdf5.framework/Resources/CMake/ Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
config/HDFMacros.cmake
Outdated
| # - Frameworks: <framework>/Resources/CMake/ | ||
| # - Windows (not Cygwin): cmake/ | ||
| # - Linux/Unix/Cygwin: ${CMAKE_INSTALL_LIBDIR}/cmake/<package_name>/ | ||
| if (${package_prefix}_BUILD_FRAMEWORKS) |
Collaborator
There was a problem hiding this comment.
I believe only the Unixy changes need to be put in this particular spot. It seems unlikely that HDF5_USE_GNU_DIRS is going to be ON on Windows or Apple. There may be a use case for Apple, but that would seem to go against the frameworks approach anyway.
Add similar change to HDF5Examples/config/HDFMacros.cmake.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update HDF_DIR_PATHS macro to install hdf5-config.cmake and related files to platform-appropriate locations: