Remove (HD)off_t from the H5Pset/get_external calls#5809
Remove (HD)off_t from the H5Pset/get_external calls#5809derobins wants to merge 1 commit intoHDFGroup:developfrom
Conversation
* Remove off_t from H5Pset/get_external() calls * Remove off_t from set/getExternal() C++ calls * Remove off_t from the Fortran interface * Remove OFF_T as a Fortran INTEGER KIND HDoff_t remains in a few places where it's used in POSIX I/O calls.
|
This PR replaces #5082, which was wildly out of date. |
brtnfld
left a comment
There was a problem hiding this comment.
I would remove the C wrappers for Fortran and call the C API directly, as long as we are doing updates anyway. I can do that later if you'd like.
I'll update it tonight. |
There was a problem hiding this comment.
Accidentally approved; We decided that for consistency it would be a good idea to version H5Pset/get_external. @derobins could you do this?
I can but it'll take more time. I'll have to write tests, etc. |
Supporting off_t is a pain on Windows and is only used in one
pair of public API calls, where it's semantically odd because
negative values aren't allowed.
This PR removes off_t and replaces it with uint64_t.
Internally, HDoff_t remains in a few places where it's used
in POSIX I/O calls.
Important
Replace
off_twithuint64_tin HDF5 external file interfaces for better Windows compatibility.off_twithuint64_tinH5Pset_external()andH5Pget_external()inH5Pdcpl.candH5Ppublic.h.setExternal()andgetExternal()inH5DcreatProp.cppandH5DcreatProp.hto useuint64_t.h5pset_external_c()andh5pget_external_c()inH5Pf.candH5Pff.F90to useuint64_t_f.OFF_Tas a Fortran INTEGER KIND inH5match_types.c.offsetparameter touint64_tinh5pDCPLImp.c.RELEASE.txtto reflect changes in offset parameter types and removal ofOFF_T.HDoff_tusage remains for POSIX I/O calls inH5Defl.candH5FDstdio.c.This description was created by
for cc4a37f. You can customize this summary. It will automatically update as commits are pushed.