Conversation
mattjala
reviewed
May 8, 2025
| if name == "ref": | ||
| dt = None | ||
| if val is Reference: | ||
| dt = np.dtype("S48", metadata={"ref": Reference}) |
There was a problem hiding this comment.
Why are references represented as 48-character strings? Is this adhering to some constraint of how h5py represents them? If the specific length is important, it would be nice to use a named constant to make this clear.
There was a problem hiding this comment.
This looks to be the length of an object ID, so it should definitely referenced a hardcoded constant value
mattjala
reviewed
May 8, 2025
| byteorder = "BE" | ||
|
|
||
| # numpy integer type - but check to see if this is the h5py | ||
| # numpy integer type - but check to see if this is the hypy |
mattjala
reviewed
May 8, 2025
| Validate a json type - call createDataType and if no exception, | ||
| it's valid | ||
| """ | ||
| createDataType(typeItem) |
There was a problem hiding this comment.
validateTypeItem needs to catch the potential exception raised by createDataType.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added objid functions to replace uuid package calls in h5db.