Pan and Zoom on Document when in Node Graph#3729
Draft
KshAbo wants to merge 1 commit intoGraphiteEditor:masterfrom
Draft
Pan and Zoom on Document when in Node Graph#3729KshAbo wants to merge 1 commit intoGraphiteEditor:masterfrom
KshAbo wants to merge 1 commit intoGraphiteEditor:masterfrom
Conversation
Member
|
!build |
|
Keavon
force-pushed
the
document-ptz-in-node-graph
branch
from
fa293ae to
84177b6
Compare
Member
|
Update: I started reviewing this but I'm concerned that its implementation is far more complicated than it needs to be, although without solving it myself, I can't be certain. I think the best approach is to have someone else who's had more time getting the experience with the code base to create a second implementation, and if that second attempt ends up being simpler, we merge that one instead. I'm going to convert this to a draft for now because of that concern and so I can continue reviewing other PRs without this still being Ready for Review like the ones I'm working through. The path forward is likely to wait on a second PR for this as a point of comparison. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
document_pan_zoom.mp4
Adds: Alt+MMB dragging to pan the artwork canvas in node graph
Ctrl+Alt+MMB drag to zoom the artwork canvas in node graph
Resolves: https://discord.com/channels/731730685944922173/881073965047636018/1364204626433409046