fixed shape at non-100% viewport zoon to apply scale correctly#3723
Draft
krVatsal wants to merge 8 commits intoGraphiteEditor:masterfrom
Draft
Conversation
cee75a5 to
94f589b
Compare
Member
|
…-scale' of https://github.com/krVatsal/Graphite into fix-shape-at-non-100%-viewport-zoom-wrongly-applies-the-scale
Contributor
Author
|
…y-applies-the-scale
…-scale' of https://github.com/krVatsal/Graphite into fix-shape-at-non-100%-viewport-zoom-wrongly-applies-the-scale
Contributor
Author
|
After analyzing the test failures, I realized that ellipse is intentionally designed to work in viewport space (visual/screen space), not document space(which was my solution for this scale issue). This is correct behavior for canvas rotation scenarios. The zoom-related fix likely only applies to shapes like Rectangle that use document space ( If there is something that i am getting wrong or if i should follow any other method please suggest. |
Member
|
Ellipse should work the same as Rectangle in that regard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2582
When drawing shapes (Rectangle, Ellipse, Circle, Polygon, Star, Arc, Spiral) at a viewport zoom other than 100%, the Transform node would receive a scale value corresponding to the zoom level instead of 1.
The fix converts viewport-space dimensions to document-space before setting shape parameters and uses
TransformIn::Localinstead ofTransformIn::Viewport. This matches how the Line tool already worked correctly.