Fix Shift constraint to start from snapped position when dragging points (#2753)#3690
Draft
afrdbaig7 wants to merge 1 commit intoGraphiteEditor:masterfrom
Draft
Fix Shift constraint to start from snapped position when dragging points (#2753)#3690afrdbaig7 wants to merge 1 commit intoGraphiteEditor:masterfrom
afrdbaig7 wants to merge 1 commit intoGraphiteEditor:masterfrom
Conversation
afrdbaig7
force-pushed
the
fix/path-tool-shift-constraint
branch
from
4f288e1 to
469e5fb
Compare
…teEditor#2753) When constraining movement with Shift during a drag, the constraint now starts from the point’s snapped position rather than the original drag start. This makes constrained movement behave more intuitively when snapping is active. The fix keeps the constraint origin stable on the first Shift press and uses the snapped mouse position so the origin doesn’t change during axis switches.
Keavon
force-pushed
the
fix/path-tool-shift-constraint
branch
from
469e5fb to
8c3ffd0
Compare
Member
|
This is letting me move it around while the snap is happening, so I'm not sure what's going on. Draw a bunch of random layers to create a bunch of snapping points, then drag an anchor over another anchor and hold Shift, then keep dragging and you'll see that it doesn't remain constrained to the horizontal or vertical line defined by the snapping point that was set upon pressing Shift in that moment the key was depressed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2753.
When dragging a point and pressing Shift to constrain movement, the constraint was starting from the original drag position instead of the snapped position, which caused an unexpected jump.
This PR fixes that by locking the constraint origin when Shift is first pressed and using the snapped mouse position, so constrained movement behaves consistently even after snapping or axis changes.
The behavior when starting a drag with Shift, releasing and re-pressing Shift, and normal dragging remains unchanged. All existing tests pass.