Skip to content

Conversation

@victorsantos-cit
Copy link
Contributor

Hello folks.
this PR is to create a support to EXT_AUTHZ_GRPC on wire_format enum Value in google_network_services_authz_extension resource

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

networkservices: added `EXT_AUTHZ_GRPC` on `google_network_services_authz_extension` resource

Added a new test case for the AuthzExtension with gRPC support and updated the wire format description to include EXT_AUTHZ_GRPC.
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Dec 26, 2025
@github-actions github-actions bot requested a review from roaks3 December 26, 2025 18:30
@github-actions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions
Copy link

@roaks3 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions
Copy link

github-actions bot commented Jan 2, 2026

@GoogleCloudPlatform/terraform-team @roaks3 This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

@victorsantos-cit
Copy link
Contributor Author

@roaks3 Hey , could you review this PR please

Copy link
Contributor

@roaks3 roaks3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming tests, but LGTM, just one minor comment

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 2, 2026
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 39 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 3 files changed, 96 insertions(+), 4 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_services_authz_extension (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_services_authz_extension" "primary" {
  wire_format = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 87
Passed tests: 85
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages
  • networkservices

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetworkServicesAuthzExtension_networkServicesAuthzExtensionBasicWithAuthGrpcExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccNetworkServicesAuthzExtension_networkServicesAuthzExtensionBasicWithAuthGrpcExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@victorsantos-cit
Copy link
Contributor Author

@roaks3 whats is the error from the network_services_authz_extension_basic_with_auth_grpc and i will update de description , thanks

@github-actions github-actions bot requested a review from roaks3 January 2, 2026 19:40
Clarified the description of the 'wireFormat' field to specify the communication format and default behavior.
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 2, 2026
@victorsantos-cit
Copy link
Contributor Author

@roaks3 whats is the error from the network_services_authz_extension_basic_with_auth_grpc and i will update de description , thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-approval Pull requests that need reviewer's approval to run presubmit tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants