Conversation
… should fail because the code is still not modified
pacowong
approved these changes
Jan 16, 2026
| - uses: actions/checkout@v4 | ||
| - run: swift sdk install https://github.com/swiftwasm/swift/releases/download/swift-wasm-6.0.2-RELEASE/swift-wasm-6.0.2-RELEASE-wasm32-unknown-wasi.artifactbundle.zip --checksum 6ffedb055cb9956395d9f435d03d53ebe9f6a8d45106b979d1b7f53358e1dcb4 | ||
| - name: Build | ||
| run: swift build --swift-sdk wasm32-unknown-wasi |
There was a problem hiding this comment.
QQ: When to use wasm32-unknown-wasip1-threads?
Member
Author
There was a problem hiding this comment.
When we need threading support. It all depends on the WASM interpreter. For this package, I think it's not the case 😃
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds CI support using GitHub actions. There is a workflow already to guarantee Swift compatibility on MacOS, this new workflow will cover our needs for WASM.
Right now, the build is going to fail because the code is obviously not compatible with XP. But future PRs will make the build pass and we will use this CI as a tool to guarantee WASM compatibility in the future as well.