Conversation
…ata, loggedhudmessage
…for end of base event struct and object
…on of player, handle jeep gunners, handle undercover player,
…asg file, reimplement ponr logic,
Removed redundant padding declaration in GenericEvent structure.
There was a problem hiding this comment.
Pull request overview
This pull request implements a new TOML-based savegame format (.asg) to replace the legacy binary format (.svl). The changes include comprehensive serialization/deserialization of game state including entities, items, triggers, events, movers, decals, and more. The implementation is marked as "WIP" (work in progress) and requires significant additional work.
Changes:
- Adds toml++ library license information and dependency
- Implements complete savegame serialization/deserialization system with TOML format
- Adds new game engine API bindings for save/restore functionality
- Introduces configuration option to toggle between new and legacy formats
Reviewed changes
Copilot reviewed 28 out of 29 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| resources/licensing-info.txt | Adds MIT license for toml++ library |
| game_patch/misc/alpine_savegame.h | Defines data structures for new savegame format |
| game_patch/misc/alpine_savegame.cpp | Implements 4800+ lines of serialization/deserialization logic |
| game_patch/misc/alpine_settings.h/cpp | Adds configuration toggle for new savegame format |
| game_patch/os/commands.cpp | Adds console command to toggle savegame format |
| game_patch/rf/*.h | Exposes additional game engine APIs for save/restore |
| game_patch/CMakeLists.txt | Includes new savegame source files |
| common/include/common/version/version.h | Defines ASG_VERSION constant |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… to avoid confusion, fix weapon savegame block struct, fix types for savegame object data block, fix some errors in savegame saving and parsing
…tate, fix corpse light level not being maintained
…and, support high accuracy pos/orient/vel
…d for some object types (item and corpse for example)
…undesired incremental rotation
…tion and deserialization logic,
… events asg approach from deleted_event_uids to match other object types and save all event instances
…eate, Alarm_Siren
…eport, teleport_player, and play_vclip, fix def for cyclic_timer event
…ot_at, shoot_once, explode, spawn_object
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
still needs a significant amount of work