[DRAFT] Split statistics components computation & output#3836
Draft
[DRAFT] Split statistics components computation & output#3836
Conversation
…hry/create-yaml-file-and-structure
…sufficient id usage
…y/create-yaml-file-and-structure
…emove break; in the streamMultilineYamlAttribute() method
…r delete the first line over and over again but loop over the lines
…ndentation as parameter
…ul at this time) + ensure that opening and writing to the file is exception-free
… + methods reanming + switch the streamMultilineYamlAttribute() method to private
…dToMsg method which takes an std::exception + add a boolean toEnd in the addToMsg methods
…ethod because this code is already exception-free
MelReyCG
changed the base branch from
develop
to
refactor/dudes/error-context
…to bugfix/rey/split-statistics-components
…to bugfix/rey/split-statistics-components
…to bugfix/rey/split-statistics-components
…S-DEV/GEOS into refactor/dudes/error-context
…to bugfix/rey/split-statistics-components
…to bugfix/rey/split-statistics-components
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #3822
On top of PR : #3829
Planned refactor: The goal is to have a way to query statistics for solver (reservoi rreference pressure for wells), with a clear separation with output statistics component.
The following plan tries to avoid recomputation by grouping statistics. It also aims to structure necessary views for kernels, in order to reduce number of lambda & function parameters.