refactor: split testing utilities out of main bundle#707
Open
SamuelAlev wants to merge 16 commits intodevfrom
Open
refactor: split testing utilities out of main bundle#707SamuelAlev wants to merge 16 commits intodevfrom
SamuelAlev wants to merge 16 commits intodevfrom
Conversation
🦋 Changeset detectedLatest commit: 1175f80 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
SamuelAlev
requested review from
anxobotana
and removed request for
oliverschwendener
anxobotana
approved these changes
Jan 23, 2024
Collaborator
|
Do we need some conditional import of the testing stuff within |
SamuelAlev
force-pushed
the
refactor/split-testing-utilities-from-main-bundle
branch
from
6b3642a to
b700348
Compare
SamuelAlev
changed the base branch from
main
to
chore/add-typing-package-json
SamuelAlev
force-pushed
the
refactor/split-testing-utilities-from-main-bundle
branch
2 times, most recently
from
d3ec91e to
8779a32
Compare
SamuelAlev
force-pushed
the
refactor/split-testing-utilities-from-main-bundle
branch
from
e7650ba to
69eebd2
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise
sinongets bundled into the blocks/themes/web-app.You will need to update the import paths in your tests:
I also had to add
getAppBridgeTestingPackageto lazy load the@frontify/app-bridge(v3.0.x) or@frontify/app-bridge/testing(future)