Remove placeholder defaults from env templates #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change VAR_NAME=$VAR_NAME pattern to VAR_NAME= in all sample app environment templates. The old pattern was a legacy from Docker deployments and caused literal $VAR_NAME strings to be populated at runtime when variables were not set.
ryanbas21
force-pushed
the
fix-env-files
branch
from
3824fe4 to
6a638f3
Compare
ancheetah
reviewed
Jan 7, 2026
| # 'flow' relies on the PingOne Protect collector for initialization | ||
| PINGONE_ENV_ID=$PINGONE_ENV_ID # required when ProtectCollector is present | ||
| WELLKNOWN_URL= | ||
| INIT_PROTECT= # bootstrap | flow |
Contributor
There was a problem hiding this comment.
I'm concerned if we leave comments on the same line we can run into the same problem. Can we move all comments to new lines?
| SCOPE= // For using "PINGONE" as the server type, the `revoke` scope must be set as well. | ||
| TIMEOUT= | ||
| WEB_OAUTH_CLIENT= | ||
| NX_NO_CLOUD=true |
| SCOPE=$SCOPE // For using "PINGONE" as the server type, the `revoke` scope must be set as well. | ||
| TIMEOUT=$TIMEOUT | ||
| WEB_OAUTH_CLIENT=$WEB_OAUTH_CLIENT | ||
| SCOPE= // For using "PINGONE" as the server type, the `revoke` scope must be set as well. |
Contributor
There was a problem hiding this comment.
Should be # instead of //?
ancheetah
reviewed
Jan 7, 2026
| REALM_PATH= | ||
| SCOPE= | ||
| TIMEOUT= | ||
| TREE= # Remove the TREE variable to use the default tree/journey |
Contributor
There was a problem hiding this comment.
I think we can actually remove this comment now
Comment on lines
+17
to
+20
| INIT_PROTECT= # bootstrap | journey | ||
| # 'bootstrap' will initialize protect at app bootstrap time | ||
| # 'journey' relies on the PingOneProtectInitialize callback for initialization | ||
| PINGONE_ENV_ID= # required when PingOne Protect callbacks are present |
Contributor
There was a problem hiding this comment.
Can we move these comments to new lines too?
Comment on lines
+1
to
+6
| SERVER_TYPE= # 'AIC' or 'PINGONE' | ||
| SERVER_URL= # AM URL for AIC or PingOne base URL with env ID for PingOne | ||
| PORT= | ||
| REALM_PATH= # 'alpha' or 'beta' for AIC server type. Not used for PingOne. | ||
| REST_OAUTH_CLIENT= # Confidential client ID for AIC or WebApp public client ID for PingOne | ||
| REST_OAUTH_SECRET= # Confidential client secret for AIC. Not used for PingOne. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://pingidentity.atlassian.net/browse/SDKS-4446
Summary
VAR_NAME=$VAR_NAMEpattern from all sample app environment templatesVAR_NAME=) to prevent literal$VAR_NAMEstrings from being populated at runtimeBackground
The old pattern was a legacy from when sample apps were deployed through Docker. This is no longer the case, and the placeholders caused issues when users didn't want to use a variable - the literal string
$VAR_NAMEwould be populated at runtime instead of an empty value.Changes
Updated 8
.env.examplefiles:angular-todo/.env.exampleangular-todo-davinci/.env.examplecentral-login-oidc/.env.exampleembedded-login/.env.exampleembedded-login-davinci/.env.examplereactjs-todo/.env.examplereactjs-todo-davinci/.env.exampletodo-api/.env.exampleTest plan
=$VAR_NAMEpatterns remain in codebaseNotes
External documentation that references the old
VAR_NAME=$VAR_NAMEpattern will need to be updated separately.