SDKS-4147: React DV - Handle Protect collector with module #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ancheetah
force-pushed
the
SDKS-4147-react-protect-module
branch
from
4c9c97f to
7e742fa
Compare
cerebrl
requested changes
Jul 24, 2025
| */ | ||
| const protectApi = getProtectApi(); | ||
| const data = await protectApi.getData(); | ||
| if (typeof data !== 'string' && 'error' in data) { |
Contributor
There was a problem hiding this comment.
I'm a bit hesitant on this type of return type, since it could either be a string or object, but let's discuss this as a team and move forward in the new Jira ticket I'll create for universal error types throughout this SDK.
cerebrl
previously approved these changes
Jul 24, 2025
Contributor
cerebrl
left a comment
cerebrl
left a comment
There was a problem hiding this comment.
The previous comments will be addressed in a separate ticket as to align both this and the React sample app for PingAM.
ancheetah
force-pushed
the
SDKS-4147-react-protect-module
branch
from
0e1d602 to
e1816b3
Compare
ancheetah
force-pushed
the
SDKS-4147-react-protect-module
branch
4 times, most recently
from
8df8a10 to
e522cc5
Compare
ancheetah
force-pushed
the
SDKS-4147-react-protect-module
branch
from
e522cc5 to
441afc7
Compare
cerebrl
approved these changes
Dec 15, 2025
Contributor
cerebrl
left a comment
cerebrl
left a comment
There was a problem hiding this comment.
Let's make sure we update Chris about these new additions, so he can add them to our docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://pingidentity.atlassian.net/browse/SDKS-4147
Updates handling of ProtectCollector in a DaVinci flow. It removes handling of the
protectsdkStart Node and instead initializes the Protect SDK and submits data collected. The Protect API is initialized with a plain module. The INIT_PROTECT flag allows for Protect to be initialized for data collection either at bootstrap or when a ProtectCollector is found in the DaVinci flow.