Skip to content

Conversation

@javier-godoy
Copy link
Member

@javier-godoy javier-godoy commented Jan 8, 2026

Summary by CodeRabbit

  • Chores
    • Updated internal test infrastructure and metadata.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 8, 2026

Walkthrough

Added the @GithubBranch("v3.x") annotation to the TwincolDemoView class along with its corresponding import statement to provide GitHub branch metadata.

Changes

Cohort / File(s) Summary
Annotation metadata
src/test/java/com/flowingcode/vaadin/addons/twincolgrid/TwincolDemoView.java
Added @GithubBranch("v3.x") class-level annotation and imported com.flowingcode.vaadin.addons.GithubBranch

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix(demo): add github branch' accurately reflects the main change: adding a @Githubbranch annotation to the demo view class.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@javier-godoy javier-godoy changed the base branch from master to v3.x January 8, 2026 17:38
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 8, 2026

@javier-godoy javier-godoy requested review from mlopezFC and paodb January 8, 2026 17:40
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In
@src/test/java/com/flowingcode/vaadin/addons/twincolgrid/TwincolDemoView.java:
- Line 35: The @GithubBranch("v3.x") annotation on the TwincolDemoView class
points to a non-existent branch and should be removed or changed; open the
TwincolDemoView class and either delete the @GithubBranch annotation entirely
(to default to master) or replace "v3.x" with an actual branch name (e.g.,
"master") so generated GitHub links are valid and the demo view no longer
references a missing branch.
📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 75b4045 and 4aea12e.

📒 Files selected for processing (1)
  • src/test/java/com/flowingcode/vaadin/addons/twincolgrid/TwincolDemoView.java
🔇 Additional comments (1)
src/test/java/com/flowingcode/vaadin/addons/twincolgrid/TwincolDemoView.java (1)

24-24: The GithubBranch annotation is properly imported from the external commons-demo dependency and correctly applied to the TwincolDemoView class with the branch reference "v3.x". No issues found.

@paodb paodb merged commit e382b5a into v3.x Jan 8, 2026
5 of 7 checks passed
@github-project-automation github-project-automation bot moved this from To Do to Pending release in Flowing Code Addons Jan 8, 2026
@paodb paodb deleted the 3.x-github-branch branch January 8, 2026 18:20
@paodb paodb moved this from Pending release to Done in Flowing Code Addons Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants