Skip to content

fix: ensure stdin state is correct for searchable multi-select prompt #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yongnianliu wants to merge 3 commits into
base: main
Choose a base branch
from
+13 −2
Open

fix: ensure stdin state is correct for searchable multi-select prompt #620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
86344e5
fix: ensure stdin state is correct for searchable multi-select prompt
yongnianliu Jan 30, 2026
be8f132
Merge branch 'main' into main
TabishB Jan 30, 2026
5a4936b
Merge branch 'main' into main
TabishB Jan 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/prompts/searchable-multi-select.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,17 @@ async function createSearchableMultiSelect(): Promise<
* - Tab to confirm selections
*/
export async function searchableMultiSelect(config: Config): Promise<string[]> {
// Fix: Ensure stdin is in the correct state BEFORE creating the prompt
// This fixes the issue where arrow keys don't work until Enter is pressed first.
// The root cause is that welcome-screen's waitForEnter() pauses stdin before this prompt starts.
const stdin = process.stdin;
if (stdin.isTTY) {
if (!stdin.isRaw) {
stdin.setRawMode(true);
}
stdin.resume();
}

const prompt = await createSearchableMultiSelect();
return prompt(config);
}
Expand Down
4 changes: 2 additions & 2 deletions src/ui/welcome-screen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,8 @@ function waitForEnter(): Promise<void> {
// Enter key or Ctrl+C
if (char === '\r' || char === '\n' || char === '\u0003') {
stdin.removeListener('data', onData);
stdin.setRawMode(wasRaw);
stdin.pause();
// Don't restore raw mode or pause stdin here - let the next prompt handle stdin state
Copy link
Contributor

@TabishB TabishB Jan 30, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The searchableMultiSelect() guard already fixes this. I'd revert this change so waitForEnter() keeps cleaning up after itself. No need for both.

// This fixes the issue where arrow keys don't work in searchableMultiSelect after welcome screen

// Handle Ctrl+C
if (char === '\u0003') {
Expand Down
Loading